Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): append id to page slugs #1746

Closed
wants to merge 6 commits into from
Closed

Conversation

tomwayson
Copy link
Member

@tomwayson tomwayson commented Nov 21, 2024

  1. Description:
  • Adds utils to append id's to slugs and parse them out again
  • updates fetch for all item-backed entities to use id appended to slug (if any)
  • updates site relative link for page items to include slug

NOTE: that the latter requires corresponding opendata-ui changes.

Also, 3d4529e refactors the computeLinks functions for item-backed entities to call a common computeItemLinks() in order to address this comment.

  1. Instructions for testing:

  2. Closes Issues: 11831

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

n/a

Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Nov 26, 2024
@github-actions github-actions bot removed the Stale Stale issue - update or it will be closed label Nov 27, 2024
Copy link

github-actions bot commented Dec 2, 2024

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Dec 2, 2024
@tomwayson
Copy link
Member Author

closing in favor of
#1756
#1758

@tomwayson tomwayson closed this Dec 4, 2024
tomwayson added a commit that referenced this pull request Dec 5, 2024
esri-dcdev-2 pushed a commit that referenced this pull request Dec 5, 2024
# @esri/hub-common [15.18.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-12-05)

### Features

* **hub-common:** add optional includeIdInSlug arg to getItemIdentifier ([#1759](#1759)) ([f54ca6d](f54ca6d)), closes [#1746](#1746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale issue - update or it will be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants